Review of "Click to close overview" version 15

Details Page Preview

Close the overview by clicking empty space.

Extension Homepage
https://github.com/l3nn4rt/click-to-close-overview

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:26
    this._gesture = new Clutter.ClickGesture()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:26
    this._gesture = new Clutter.ClickGesture()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:27
    		this._gesture.connect('recognize', action => {
    			/* ignore non-primary clicks */
    			if (action.get_button() !== 1 && action.get_button() !== 0)
    				return;
    
    			/* clicked actor */
    			const [x, y] = global.get_pointer();
    			const actor = global.stage.get_actor_at_pos(Clutter.PickMode.ALL, x, y);
    
    

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Inactive
3 Active
2 Active
1 Active

Previous Reviews on this Version

fmuellner active