Review of "Volume Scroller" version 14

Details Page Preview

Scroll up or down in the Top Bar to adjust volume. Middle-click to toggle mute. Supports configuring granularity (default step of 5%) This is a fork of https://extensions.gnome.org/extension/4109/volume-scroller/ which is now unfortunately unmaintained/archived.

Extension Homepage
https://github.com/francislavoie/gnome-shell-volume-scroller

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:54
    this.settings.connect("changed::enable-middle-click", setMiddleClick)
  • extension.js:52
    this.settings.connect("changed::granularity", setGranularity)
  • extension.js:53
    this.settings.connect("changed::invert-scroll", setDirection)

All Versions

Version Status
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active
OK