Review of "Topbar Weather" version 50.0.1 (8)

Details Page Preview

Display the current weather inside the pill next to the clock. Features: - Show/hide apparent temperature (feels like) - Show/hide temperature unit symbol (°C or °F) - Show/hide decimals in apparent temperature - Show/hide written conditions (e.g., rain, drizzle) or sky description (e.g., partly cloudly, overcast) if no active weather

Extension Homepage
https://github.com/albersonmiranda/topbar-weather

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:33
        this._topBox = new St.BoxLayout({
          style_class: "clock",
        })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:108
    this._settings.connect("changed::hide-apparent-decimals", () => this._weather.update())
  • extension.js:107
    this._settings.connect("changed::hide-units", () => this._weather.update())
  • extension.js:106
    this._settings.connect("changed::show-apparent-temp", () => this._weather.update())
  • extension.js:109
    this._settings.connect("changed::show-conditions", () => this._weather.update())

All Versions

Version Status
50.0.1 (8) Active
50.0.0 (7) Inactive
49.2.1 (6) Inactive
49.2 (5) Inactive
49.1 (4) Inactive
49.0 (3) Inactive
49.0 (2) Inactive
49.0 (1) Rejected

Previous Reviews on this Version

fmuellner active