Review of "Spotify Controls + Track Info" version 14

Details Page Preview

GNOME 45+ extension that integrates Spotify playback controls directly into your GNOME top bar. This extension is not affiliated, funded, or in any way associated with Spotify.

Extension Homepage
https://github.com/Sonath21/spotify-controls

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:94
    this._maxWidthChangedId = this._settings.connect('changed::max-width', this._onMaxWidthChanged.bind(this))
  • extension.js:291
                button.connect('button-press-event', (_actor, event) => {
                    const pressedButton = event.get_button();
    
                    if (pressedButton === Clutter.BUTTON_MIDDLE && middleHandler) {
                        try {
                            middleHandler();
                        } ca

All Versions

Version Status
15 Active
14 Rejected
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Rejected
5 Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

Sonath21 posted a review
Reject this application, i messed up, wrong files. Thanks
Sonath21 auto- rejected
Auto-rejected because of new version 15 was uploaded