Review of "Dynamic Wallpaper Fetcher" version 1

Details Page Preview

Fetches daily wallpapers from multiple sources. Includes history navigation.


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:30
                this._controlsItem = new PopupMenu.PopupBaseMenuItem({ 
                    reactive: false, 
                    can_focus: false
                })
  • extension.js:59
                this._nextBtn = new St.Button({
                    style_class: 'button',
                    can_focus: true,
                    x_expand: true,
                    child: new St.Icon({ 
                        icon_name: 'media-seek-forward-symbolic', 
                        icon_size: 16,
                    
  • extension.js:43
                this._prevBtn = new St.Button({
                    style_class: 'button',
                    can_focus: true,
                    x_expand: true,
                    child: new St.Icon({ 
                        icon_name: 'media-seek-backward-symbolic', 
                        icon_size: 16,
                   

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:30
                this._controlsItem = new PopupMenu.PopupBaseMenuItem({ 
                    reactive: false, 
                    can_focus: false
                })
  • extension.js:59
                this._nextBtn = new St.Button({
                    style_class: 'button',
                    can_focus: true,
                    x_expand: true,
                    child: new St.Icon({ 
                        icon_name: 'media-seek-forward-symbolic', 
                        icon_size: 16,
                    
  • extension.js:43
                this._prevBtn = new St.Button({
                    style_class: 'button',
                    can_focus: true,
                    x_expand: true,
                    child: new St.Icon({ 
                        icon_name: 'media-seek-backward-symbolic', 
                        icon_size: 16,
                   

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:87
    this._settings.connect('changed::icon-position', () => this._applyIconPosition())
  • extension.js:88
    this._settings.connect('changed::update-interval', () => this._resetTimer())

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:15
    this._session = new Soup.Session()

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

Nester auto- rejected
Auto-rejected because of new version 2 was uploaded