Review of "Dynamic Wallpaper Fetcher" version 2

Details Page Preview

Fetches daily wallpapers from multiple sources. Includes history navigation.


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:52
                this._nextBtn = new St.Button({
                    style_class: 'button', can_focus: true, x_expand: true,
                    child: new St.Icon({ icon_name: 'media-seek-forward-symbolic', icon_size: 16, x_align: Clutter.ActorAlign.CENTER })
                })
  • extension.js:40
                this._prevBtn = new St.Button({
                    style_class: 'button', can_focus: true, x_expand: true,
                    child: new St.Icon({ icon_name: 'media-seek-backward-symbolic', icon_size: 16, x_align: Clutter.ActorAlign.CENTER })
                })
  • extension.js:46
                this._removeBtn = new St.Button({
                    style_class: 'button', can_focus: true, x_expand: true,
                    child: new St.Icon({ icon_name: 'edit-delete-symbolic', icon_size: 16, x_align: Clutter.ActorAlign.CENTER })
                })

All Versions

Version Status
2 Unreviewed
1 Rejected