Review of "Kerberos login" version 20

Details Page Preview

Provide a system menu item to renew Kerberos tickets

Extension Homepage
https://gitlab.com/bonzini/gnome-kinit

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • extension.js:174
    Extension.lookupByURL(import.meta.url)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:149
    this.menuItem = new PopupMenu.PopupMenuItem(this._account.PresentationIdentity, false)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:150
    this.menuItem.connect('activate', this._clicked.bind(this))
  • extension.js:204
    this.menu.connect('open-state-changed', this._subMenuOpenStateChanged.bind(this))

All Versions

Previous Reviews on this Version

fmuellner active