Review of "Named Workspaces" version 4

Details Page Preview

Displays the current workspace name in the top panel with inline editing via double-click

Extension Homepage
https://github.com/a31labs/gnome-named-workspaces

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.workspace-name.gschema.xml
    id='org.gnome.shell.extensions.named-workspaces' path='/org/gnome/shell/extensions/named-workspaces/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:332
            this.menu.connect('open-state-changed', (_menu, isOpen) => {
                if (isOpen) {
                    this._buildWorkspaceList();
                    this._populateMenu();
                } else {
                    this._commitMenuChanges();
                }
            })

All Versions

Version Status
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active