Review of "Peek Bar" version 9

Details Page Preview

Intelligently hides the native GNOME top bar.

Extension Homepage
https://github.com/rachalaraj/peek-bar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:56
          this._settings.connect('changed::intellihide', () => {
            this.quickToggle.checked = this._settings.get_boolean('intellihide')
          })
  • extension.js:52
          this.quickToggle.connect('clicked', () => {
            this._settings.set_boolean('intellihide', this.quickToggle.checked)
          })

All Versions

Version Status
16 Active
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active
You probably want to fix your README :-) The shexli warning about the Gio.Settings signal is also valid - consider switching to connectObject()