GNOME Shell Extensions

Review of "GOCR" version 2

Details Page Preview

GOCR

by LeonidN

Select a screen area and copy the recognized text to clipboard (requires tesseract-ocr) Look README in repository for details

Extension Homepage
https://github.com/EvilX/gocr
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:287 
    St.Clipboard.get_default()

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

LeonidN posted a review
LeonidN posted a review
fmuellner active
Note that spawning wl-copy is unnecessarily complex. You can read the file's contents into a Gio.Bytes object, then use `St.Clipboard.get_default().set_content(St.ClipboardType.CLIPBOARD, 'image/png', bytes)` to save it to the clipboard.