Review of "Multicore System Monitor" version 10

Details Page Preview

Show consumption of each CPU core and memory

Extension Homepage
https://github.com/igrek51/multicore-monitor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:49
    GLib.file_get_contents(file)
  • extension.js:91
    GLib.file_get_contents(file)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:170
            this.area = new St.DrawingArea({
                reactive: false,
                width: CPU_GRAPH_WIDTH + MEMORY_GRAPH_WIDTH,
                height: 100,
                style_class: 'graph-drawing-area',
            })
  • extension.js:184
    this.dynamicLabel = new St.Label({ text: "" })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:170
            this.area = new St.DrawingArea({
                reactive: false,
                width: CPU_GRAPH_WIDTH + MEMORY_GRAPH_WIDTH,
                height: 100,
                style_class: 'graph-drawing-area',
            })
  • extension.js:184
    this.dynamicLabel = new St.Label({ text: "" })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:176
    this.area.connect('repaint', this._draw.bind(this))

All Versions

Version Status
10 Active
9 Active
8 Active
7 Inactive
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active