Review of "User Name Indicator" version 1

Details Page Preview

Shows user, host or session name indicator in the Quick Settings area of the top panel.

Extension Homepage
https://github.com/WinAndronuX/usernameindicator

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • po/es.po
    po/es.po

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:12
        this._box = new St.BoxLayout({
          y_align: Clutter.ActorAlign.CENTER,
          x_align: Clutter.ActorAlign.START,
          style_class: "panel-button",
        })
  • extension.js:18
        this._label = new St.Label({
          text: "...",
          y_align: Clutter.ActorAlign.CENTER,
        })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:33
    this._settings.connect("changed::custom-format", () => this._updateLabel())
  • extension.js:30
        this._settings.connect("changed::indicator-type", () =>
          this._updateLabel(),
        )

All Versions

Version Status
2 Active
1 Active

Previous Reviews on this Version

fmuellner active
It would be better to explicitly disconnect the settings signals on disable. Otherwise there's a window after disable when the object hasn't been garbage collected yet, and can therefore still emit signals. The warnings about build artifacts are valid as well.
ldaniel.salazars posted a review
I'll follow your recommendations, thank you