Review of "DragnTile" version 26.03.01 (19)

Details Page Preview

Tile windows from the gnome overview.

Extension Homepage
https://github.com/Z-oops/DragnTile

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1

Shexli found 1 issue that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • extension.js:349
    metaWindow.unmaximize(Meta.MaximizeFlags.HORIZONTAL)
  • extension.js:350
    metaWindow.unmaximize(Meta.MaximizeFlags.VERTICAL)

All Versions

Version Status
26.03.01 (19) Active
26.03.01 (18) Rejected
25.12.01 (17) Active
25.11.3 (16) Active
25.11.2 (15) Active
25.11.1 (14) Rejected
25.09.5 (13) Active
25.09.4 (12) Active
25.09.3 (11) Inactive
25.09.2 (10) Inactive
25.09.1 (9) Inactive
25.06.1 (8) Active
25.05.1 (7) Active
25.03.2 (6) Active
25.03.1 (5) Active
25.03.1 (4) Rejected
25.02.2 (3) Active
25.02.1 (2) Inactive
1 Inactive

Previous Reviews on this Version

Zengl posted a review
Hi Reviewer, There is an error reported by Shexli, which is for the compatibility of older gnome versions. I think it works well. Thanks. static unmaximize(metaWindow) { if (metaWindow.set_unmaximize_flags) { metaWindow.set_unmaximize_flags(Meta.MaximizeFlags.BOTH); } else if (metaWindow.unmaximize) { // https://gjs.guide/extensions/development/targeting-older-gnome.html#feature-detection // <= gnome48, it's for compatibility with diffrent gnome versions. metaWindow.unmaximize(Meta.MaximizeFlags.HORIZONTAL); metaWindow.unmaximize(Meta.MaximizeFlags.VERTICAL); } }
fmuellner active