Review of "Wifi QR Code" version 2.5.0 (19)

Details Page Preview

This extension add a switch to the WiFi menu, in the GNOME system menu, that show a QR Code of the active connection. This can be useful for quickly connecting devices capable of reading QR Code and applying the settings to the system, without having to type in the name and the password of the WiFi. (e.g. Android Smartphone). From version 4 added a functionality to copy the QR Code to clipboard with right click on it.

Extension Homepage
https://gitlab.gnome.org/glerro/gnome-shell-extension-wifiqrcode

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • QrCode.js:233
    imageFile.load_bytes(null)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • QrCode.js:245
    St.Clipboard.get_default()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • QrCode.js:127
    console.error(e.message, 'Wifi QR Code')
  • QrCode.js:73
    console.log(`${this._extensionName}: Collecting Wifi Settings`)
  • QrCode.js:168
    console.log(`${this._extensionName}: Generating Wifi QR Code`)
  • QrCode.js:186
    console.log(`${this._extensionName}: An error occurred generating the QR Code`)
  • QrCode.js:229
    console.log(`${this._extensionName}: Temp file to copy in the clipboard not found`)
  • QrCode.js:236
    console.log(`${this._extensionName}: Error reading temp file to copy in the clipboard`)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • WifiQrCode.js:64
    console.log(`${this._extensionName}: Gnome Shell is not inizialized`)
  • WifiQrCode.js:80
    console.log(`${this._extensionName}: Gnome Shell is not inizialized`)
  • WifiQrCode.js:93
    console.log(`${this._extensionName}: Device Added: ${device.product}`)
  • WifiQrCode.js:102
    console.log(`${this._extensionName}: Adding menu....`)
  • WifiQrCode.js:106
    console.log(`${this._extensionName}: Device item not ready, waiting...`)
  • WifiQrCode.js:163
    console.log(`${this._extensionName}: Device Removed: ${device.product}`)
  • WifiQrCode.js:171
    console.log(`${this._extensionName}: Removing menu....`)
  • WifiQrCode.js:188
    console.log(`${this._extensionName}: Device State Changed: ${device.product}`)
  • WifiQrCode.js:203
    console.log(`${this._extensionName}: Destroying....bye bye`)

All Versions

Version Status
2.6.1 (20) Active
2.5.0 (19) Active
2.5.0 (18) Active
2.4.0 (17) Active
2.3.0 (16) Active
2.2.0 (15) Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

fmuellner active