GNOME Shell Extensions

Review of "Arrange Windows" version 35

Details Page Preview

Arrange Windows

by sun_wang

Arrange windows on the monitors Hotkeys: Ctrl+Alt+1 Cascade windows Ctrl+Alt+2 Tiling windows Ctrl+Alt+3 Side by side windows Ctrl+Alt+4 Stack windows Ctrl+Alt+5 Master Left Ctrl+Alt+6 Master Right Note: The Master window is gonna be the currently focused window.

Extension Homepage
https://github.com/sunwxg/gnome-shell-extension-arrangeWindows
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.unlockDialogBackground.gschema.xml 
    id='org.gnome.shell.extensions.arrangeWindows' path='/org/gnome/shell/extensions/arrangeWindows/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:495 
    this._slider.connect('drag-end', this._sliderChanged.bind(this))

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:213 
        getPreferencesWidget() {
        return buildPrefsWidget(this.getSettings());
    }

All Versions

Previous Reviews on this Version

fmuellner active