Review of "Stopwatch" version 19

Details Page Preview

Simple stopwatch extension for Gnome 40-50. Tap the primary button to start/pause the watch, secondary or long press to reset it. Automatically pauses when the screen is locked and resumes on unlocking. Preserves the state, if paused manually.

Extension Homepage
https://github.com/aliakseiz/stopwatch

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:73
            this._clickGesture.connect('recognize', (action) => {
                const button = action.get_button();
                if (button === 3) { // Secondary
                    this._reset();
                } else if (button === 1 || button === 0) { // Primary
                    this._toggleTimer();
               
  • extension.js:86
            this._longPress.connect('recognize', () => {
                this._reset();
                return Clutter.EVENT_STOP;
            })

All Versions

Version Status
19 Active
18 Inactive
17 Inactive
16 Inactive
15 Inactive
14 Active
13 Active
12 Active
11 Active
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Active
5 Rejected
4 Active
3 Active
2 Inactive
1 Rejected

Previous Reviews on this Version

fmuellner active