Review of "PHP Laravel Valet" version 12

Details Page Preview

A PHP Laravel Valet status indicator and manager.

Extension Homepage
https://github.com/rahulhaque/php-laravel-valet-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • utils.js:5
    GLib.spawn_command_line_sync(cmd)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:20
                this._settings.connect('changed', () => {
                    this._refreshIndicator()
                    this._refreshMenu()
                })
  • extension.js:33
                this.menu.connect('open-state-changed', (menu, open) => {
                    if (open) {
                        this._refreshMenu()
                    }
                })

All Versions

Version Status
12 Active
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Active
6 Inactive
5 Active
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

fmuellner active