Review of "Panel corners" version 15

Details Page Preview

A GNOME shell extension to keep the old topbar corners, which were removed for GNOME 42. It also allows you to customize the rounded corners, even if you use GNOME 40 or 41. It is widely based on already existing gnome-shell code, and on a merge request by Alice Mikhaylenko: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1328

Extension Homepage
https://github.com/aunetx/panel-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:40
            this.#connections.connect(
                Main.layoutManager,
                'monitors-changed',
                () => this.update()
            )
  • extension.js:46
            this.#connections.connect(
                global.display,
                'workareas-changed',
                () => this.update()
            )
  • extension.js:54
                this.#connections.connect(
                    Main.layoutManager,
                    'startup-complete',
                    this.load.bind(this)
                )

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:119
    this.preferences = new Settings(Keys, this.getSettings())

All Versions

Version Status
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active