Review of "FnLock switch for Lenovo ThinkPad keyboards" version 21

Details Page Preview

FnLock switch for Lenovo ThinkPad Compact USB Keyboard and Lenovo ThinkPad Trackpoint Keyboard II

Extension Homepage
https://github.com/goloshubov/fnlock-switch-tp-comp-usb-kb

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:31
    file.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:115
            this._button.connect('button-press-event', () => {
                this.switch_fnlock_state();
            })
  • extension.js:138
            this._fnlock_monitor.connect('changed', () => {
                this.update_fnlock_monitor();
                //this.update_fnlock_icon();
            })
  • extension.js:88
                    this._fnlock_monitor_target.connect('changed', () => {
                        this.update_fnlock_icon();
                    })

All Versions

Version Status
21 Active
20 Active
19 Rejected
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Rejected
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

fmuellner active