Review of "GDeej" version 9

Details Page Preview

Control your audio with a DIY volume mixer

Extension Homepage
https://github.com/sosloow/gnome-shell-extension-gdeej

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • serial.js:76
    console.warn(err)
  • serial.js:98
    console.warn(err)
  • serial.js:125
    console.warn(err)
  • serial.js:134
    console.warn(err)
  • serial.js:158
    console.warn(err)
  • serial.js:171
    console.warn(err)
  • serial.js:180
    console.warn(err)
  • serial.js:224
    console.warn(err)
  • serial.js:322
    console.warn(err)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active