Review of "SystemQuest" version 1

Details Page Preview

Turns your system resource usage (CPU, RAM, disk, network, keyboard, mouse) into an RPG character-building mini-game. Earn XP, level up stats, unlock achievements and discover your class.

Extension Homepage
https://github.com/local/system-rpg

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/rpgEngine.js:168
    file.load_contents(null)
  • lib/systemMonitor.js:91
    GLib.file_get_contents('/proc/diskstats')
  • lib/systemMonitor.js:124
    GLib.file_get_contents('/proc/net/dev')
  • lib/systemMonitor.js:158
    GLib.file_get_contents('/proc/uptime')

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:15
    this._interfaceSettings = new Gio.Settings({ schema_id: 'org.gnome.desktop.interface' })

All Versions

Version Status
1 Active

Previous Reviews on this Version

fmuellner active