Review of "Tailscale" version 0.1.0 (1)

Details Page Preview

An intuitive, feature-rich, and elegant Tailscale integration for GNOME. Nothing more, nothing less. Discover all features on the extension homepage. Trademark notice: This project is not affiliated with, sponsored by, or endorsed by Tailscale Inc. "Tailscale" is a trademark of Tailscale Inc.

Extension Homepage
https://github.com/Disk-MTH/Tailscale-Gnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • lib/menu.js:1660
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:69
    id

All Versions

Version Status
1.0.3 (7) Active
1.0.2 (6) Active
1.0.1 (5) Active
1.0.0 (4) Rejected
0.2.1 (3) Active
0.2.0 (2) Rejected
0.1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. D-Bus interface name should start with `org.gnome.Shell.Extensions` (line 32-36 `extension.js`). 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. Timeout should be removed on disable and before creating a new one: - line 240 `extension.js` - line 806, 1639 `lib/menu.js` - line 865 `lib/tailscale.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 4. You cannot use spawn command to copy files: - line 372 `lib/tailscale.js` - line 582 `prefs.js` 5. `this._destroyed` is a bad practice. Please remove it. 6. There are many privileged spawns in `lib/tailscale.js`. You cannot do those in GNOME Shell extension process where the command is not completely clear. 7. `nautilus` folder cannot be there since this is a GNOME Shell extension not nautilus extension package. 8. Unnecessary `?.` and try-catch wrappers need to be removed: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated)