Review of "Tailscale" version 1.0.0 (4)

Details Page Preview

An intuitive, feature-rich, and elegant Tailscale integration for GNOME. Nothing more, nothing less. Discover all features on the extension homepage. Trademark notice: This project is not affiliated with, sponsored by, or endorsed by Tailscale Inc. "Tailscale" is a trademark of Tailscale Inc.

Extension Homepage
https://github.com/Disk-MTH/Tailscale-Gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • lib/menu.js:1153
    St.Clipboard.get_default()

All Versions

Version Status
1.0.2 (6) Active
1.0.1 (5) Active
1.0.0 (4) Rejected
0.2.1 (3) Active
0.2.0 (2) Rejected
0.1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. That's not really the extension responsibility (line 507-514 `lib/menu.js`). 2. The commands should be moved to d-bus as the official app is offering it: https://tailscale.com/docs/features/client/linux-systray 3. You cannot use spawn for getting GNOME Shell version (line 317 `prefs/help.js`). Already in the misc.