Review of "Restore Geometry" version 6

Details Page Preview

An extension to automatically restore its previous geometry of window upon its opening

Extension Homepage
https://github.com/upsuper/gnome-extension-restore-geometry

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:307
    this._impl = new RestoreGeometryExtension(this.getSettings())
  • extension.js:23
    this._windowList = new WindowListToggle(this)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:277
            this.menu.connect('open-state-changed', (_menu, open) => {
                if (open) {
                    this._updateMenu();
                }
                return false;
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:27
                GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                    this._onWindowCreated(window);
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Version Status
8 Active
7 Rejected
6 Rejected
5 Active
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

upsuper auto- rejected
Auto-rejected because of new version 7 was uploaded