GNOME Shell Extensions

Review of "Restore Geometry" version 8

Details Page Preview

Restore Geometry

by upsuper

An extension to automatically restore its previous geometry of window upon its opening

Extension Homepage
https://github.com/upsuper/gnome-extension-restore-geometry
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:326 
    this._impl = new RestoreGeometryExtension(this.getSettings())
  • extension.js:24 
    this._windowList = new WindowListToggle(this)

All Versions

Version Status
8 Active
7 Rejected
6 Rejected
5 Active
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

upsuper posted a review
I don't quite understand what does the Shexli warning wants me to fix. It seems to me everything is properly released already.
JustPerfection active
That's a false positive. No worries.