Review of "Ping" version 19

Details Page Preview

A Ping Extension

Extension Homepage
https://github.com/prasanthc41m/ping-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:272
    file.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:72
          this._centerButton.connect('clicked', () => {
            this.panelPosition = 'center';
            this._saveSettings();
            this._updateButtonStyles();
            this._updatePosition();
            this.menu.close();
          })
  • extension.js:38
          this._entry.clutter_text.connect('activate', () => {
            this.domainToPing = this._entry.get_text();
            this._saveSettings();
            this.menu.close();
          })
  • extension.js:63
          this._leftButton.connect('clicked', () => {
            this.panelPosition = 'left';
            this._saveSettings();
            this._updateButtonStyles();
            this._updatePosition();
            this.menu.close();
          })
  • extension.js:117
          this._orderInput.clutter_text.connect('activate', () => {
            const value = parseInt(this._orderInput.get_text()) || 0;
            this.panelOrder = Math.max(0, value);
            this._orderInput.set_text(this.panelOrder.toString());
            this._saveSettings();
            this._updatePosition();
  • extension.js:81
          this._rightButton.connect('clicked', () => {
            this.panelPosition = 'right';
            this._saveSettings();
            this._updateButtonStyles();
            this._updatePosition();
            this.menu.close();
          })

All Versions

Version Status
19 Unreviewed
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Rejected
11 Active
10 Rejected
9 Rejected
8 Inactive
7 Rejected
6 Inactive
5 Rejected
4 Active
3 Active
2 Inactive
1 Active