Review "Network Stats" version 35 - GNOME Shell Extensions

Review of "Network Stats" version 35

Details Page Preview

Network Stats

Displays internet upload speed, download speed, bandwidth, data usage. visit github page for instructions, suggestions and feature requests. ERROR while updating extension ? restart your system or reload gnome shell.

Extension Homepage: https://github.com/noroadsleft000/gnome-network-stats

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

lib/net/DeviceMonitor.js:163
```
GLib.file_get_contents("/proc/net/dev")
```

lib/net/DeviceMonitor.js:201

GLib.file_get_contents("/proc/net/route")

lib/net/NetworkMonitor.js:17
```
GLib.file_get_contents("/proc/net/dev")
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

schemas/gschemas.compiled
```
schemas/gschemas.compiled
```

All Versions

Version	Status
35	Unreviewed
34	Active
33	Rejected
32	Active
31	Active
30	Rejected
29	Rejected
28	Inactive
27	Inactive
26	Active
25	Rejected
24	Active
23	Rejected
22	Rejected
21	Rejected
20	Active
19	Active
18	Active
17	Active
16	Rejected
15	Active
14	Active
13	Active
12	Active
11	Rejected
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Inactive
3	Inactive
2	Rejected
1	Rejected