Review of "Network Stats" version 35

Details Page Preview

Displays internet upload speed, download speed, bandwidth, data usage. visit github page for instructions, suggestions and feature requests. ERROR while updating extension ? restart your system or reload gnome shell.

Extension Homepage
https://github.com/noroadsleft000/gnome-network-stats

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/net/DeviceMonitor.js:163
    GLib.file_get_contents("/proc/net/dev")
  • lib/net/DeviceMonitor.js:201
    GLib.file_get_contents("/proc/net/route")
  • lib/net/NetworkMonitor.js:17
    GLib.file_get_contents("/proc/net/dev")

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Previous Reviews on this Version

JustPerfection rejected
Please remove `schemas/gschemas.compiled` and send it again. Not needed for 45+ packages.