GNOME Shell Extensions

Review of "axet's System Monitor" version 27

Details Page Preview

axet's System Monitor

by axet

# Installation Required system dependencies: * sudo apt install gir1.2-gtop-2.0 fonts-noto-color-emoji * sudo yum install libgtop2 * sudo pacman -S libgtop ## CPU wattage support (AMD/Intel) * sudo apt install sysfsutils ``` /etc/sysfs.conf mode class/powercap/intel-rapl:0/energy_uj = 0444 mode class/powercap/intel-rapl:0:0/energy_uj = 0444 ``` ## hddtemp ``` /etc/modules-load.d/drivetemp.conf drivetemp ``` ## CPU Fans Edit options.js file with correct CPU Fan driver name or label. ## Other customization Edit options.js file.

Extension Homepage
https://gitlab.com/axet/gnome-shell-extension-system-monitor
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • utils.js:140 
    file.load_contents(null)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:171 
    this.menu.connect('active-changed', (a, b) => this._menu_changed(a, b))

All Versions