Review of "Mullvad Indicator" version 23

Details Page Preview

Mullvad connection status indicator

Extension Homepage
https://github.com/Pobega/gnome-shell-extension-mullvad-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:48
            refreshItem.actor.connect('activate', () => {
                mullvad._pollMullvad();
            })
  • extension.js:55
            settingsItem.actor.connect('activate', () => {
                this._extension.openPreferences();
            })

All Versions

Version Status
25 Active
24 Active
23 Rejected
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Rejected
14 Active
13 Active
12 Rejected
11 Active
10 Active
9 Rejected
8 Active
7 Rejected
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please remove `schemas/gschemas.compiled` and send it again.