Review of "Stretch & Break Reminder" version 1

Details Page Preview

Smart health companion reminding you to stretch and rest your eyes using idle detection


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:285
            this._overlay = new StretchBreakOverlay(this, breakSec, (postponed) => {
                this._overlay = null;
                if (postponed) {
                    this._postponeTimer();
                } else {
                    this._resetTimer();
                }
            })
  • extension.js:157
            this._panelLabel = new St.Label({
                text: '🧘 --m',
                y_align: Clutter.ActorAlign.CENTER,
                style_class: 'stretch-reminder-label'
            })
  • extension.js:169
    this._statusItem = new PopupMenu.PopupMenuItem('Trạng thái: Hoạt động', { reactive: false })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:99
            this._sizeChangedId = global.display.connect('workareas-changed', () => {
                this.set_size(global.stage.width, global.stage.height);
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:104
            this._timerId = GLib.timeout_add_seconds(
                GLib.PRIORITY_DEFAULT,
                1,
                () => {
                    this.durationRemaining--;
                    if (this.durationRemaining <= 0) {
                        this.close(false);
                        return GLib.SOURCE_REMOVE;
     

All Versions

Version Status
3 Waiting for author
2 Rejected
1 Rejected

Previous Reviews on this Version

thangtran0111 auto- rejected
Auto-rejected because of new version 2 was uploaded