Review of "Stretch & Break Reminder" version 2

Details Page Preview

Smart health companion reminding you to stretch and rest your eyes using idle detection


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:129
            this._panelLabel = new St.Label({
                text: '🧘 --m',
                y_align: Clutter.ActorAlign.CENTER,
                style_class: 'stretch-reminder-label'
            })
  • extension.js:141
    this._statusItem = new PopupMenu.PopupMenuItem('Trạng thái: Hoạt động', { reactive: false })
  • extension.js:59
            this.timerLabel = new St.Label({
                style_class: 'stretch-timer',
                text: `${this.durationRemaining}s`
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:59
            this.timerLabel = new St.Label({
                style_class: 'stretch-timer',
                text: `${this.durationRemaining}s`
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:81
            this._timerId = GLib.timeout_add_seconds(
                GLib.PRIORITY_DEFAULT,
                1,
                () => {
                    this.durationRemaining--;
                    if (this.durationRemaining <= 0) {
                        this.closeDialog(false);
                        return GLib.SOURCE_REM

All Versions

Version Status
3 Waiting for author
2 Rejected
1 Rejected

Previous Reviews on this Version

thangtran0111 auto- rejected
Auto-rejected because of new version 3 was uploaded