Review of "Waywallen" version 0.2.4 (1)

Details Page Preview

Wallpaper plugin for the waywallen daemon.

Extension Homepage
https://github.com/waywallen

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 3 warning 4

Shexli found 7 issues that may need reviewer attention.

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • windowState.js:130
    w.get_maximized?.()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-001 error

GSettings schema id must use org.gnome.shell.extensions base

GSettings schema id must start with `org.gnome.shell.extensions`.

GSettings Schemas

  • schemas/org.waywallen.gnome.gschema.xml
    id='org.waywallen.gnome' path='/org/waywallen/gnome/'

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/org.waywallen.gnome.gschema.xml
    id='org.waywallen.gnome' path='/org/waywallen/gnome/'

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • renderer/renderer.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • windowManager.js:29
    window.connect('notify::title',
                () => this._parseTitle())

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:66
                GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                    this._innerEnable();
                    return GLib.SOURCE_REMOVE;
                })
  • windowManager.js:89
                GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                    try { this._window?.lower(); } catch (_e) {}
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Version Status
0.2.4 (2) Unreviewed
0.2.4 (1) Rejected

Previous Reviews on this Version

hypengw auto- rejected
Auto-rejected because of new version 0.2.4 (2) was uploaded