Review of "Waywallen" version 0.2.4 (2)

Details Page Preview

Wallpaper plugin for the waywallen daemon.

Extension Homepage
https://github.com/waywallen

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • renderer/renderer.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • windowManager.js:25
    window.connect('notify::title',
                () => this._parseTitle())

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • windowManager.js:84
                this._lowerIdleId = GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                    this._lowerIdleId = 0;
                    try { this._window?.lower(); } catch (_e) {}
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Version Status
0.2.4 (2) Unreviewed
0.2.4 (1) Rejected