Review of "Touchpad Gesture Customization" version 20

Details Page Preview

An extension which enable touchpad gestures customization in GNOME using Wayland. For full list of supported features please visit https://github.com/HieuTNg/touchpad-gesture-customization

Extension Homepage
https://github.com/HieuTNg/touchpad-gesture-customization

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:33
    this.settings = this.getSettings()
  • src/pinchGestures/showDesktop.js:31
    this._container = new Clutter.Actor({ visible: false })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • src/snapWindow.js:52
    this._adjustment.connect('notify::value', this._valueChanged.bind(this))

All Versions

Version Status
23 Active
22 Active
21 Rejected
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Rejected
13 Active
12 Rejected
11 Active
10 Active
9 Inactive
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active