Review of "Put Windows" version 38

Details Page Preview

Fully customizable replacement for the old compiz put plugin. * Move windows to left/right side, bottom/top, center or corner * Move window to other screen * Select focused window using the keyboard * Application based window placement Please check github if your gnome-shell version is not supported

Extension Homepage
https://github.com/negesti/gnome-shell-extensions-negesti

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:43
    this._windowTracker = Shell.WindowTracker.get_default()

All Versions

Previous Reviews on this Version

JustPerfection active
Nesta posted a review
Not sure if Shexli was auto generated or if it the review. * Really unsure if "schemas/gschemas.compiled" should be removed, file is included since 2019 and i have only implemented translation and don't really know how gschema works * It's an inner class that creates the tracker in _init(), Thought it is ok, as the extension null the class in disable. Should be moved to enable/disable and destroyed there?
JustPerfection posted a review
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. You can just null it out.