Review of "sanad" version 2.6 (11)

Details Page Preview

a dns changer tool for gnome extention

Extension Homepage
https://github.com/MirS0bhan/sanad

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:176
    userCsvFile.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:84
    			this.menu.connect("open-state-changed", (menu, isOpen) => {
    				if (isOpen) this._updateCurrentDNS();
    			})

All Versions

Version Status
2.6 (11) Active
2.5 (10) Active
2.5 (9) Rejected
2.5 (8) Rejected
2.4 (7) Active
2.3 (6) Inactive
2.2 (5) Active
2.1 (4) Inactive
2.1 (3) Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection active
For fixing the first Shexli's warning: [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async)