Review of "Chronos Time Tracker" version 14

Details Page Preview

Time tracker tool Mange and track your time. Features: - tracking time - display customisation - log to file start/pause - optional pause of tracking on screen lock (hibernate/shutdown) - reset to particular time value

Extension Homepage
https://github.com/0vvland/chronos

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:252
    this._indicator = new Chronos(this)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:30
    this._settings.connect('changed', this.onChangeSettings.bind(this))

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:78
          this._timeout = GLib.timeout_add(1000, GLib.PRIORITY_LOW, () => {
            // every 2 collected minutes store them
            if (getUintTime() - this._startTime > 60 * 2) {
              this.storeCountedTime();
            }
            this.refreshIndicatorLabel();
            return true;
          })

All Versions

Version Status
15 Active
14 Rejected
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages.