GNOME Shell Extensions

Review of "Simple Tiling" version 22

Details Page Preview

Simple Tiling

by Domoel

A Simple Tiling Extension for Gnome Shell.

Extension Homepage
https://git.ztfr.eu/Dome/Simple-Tiling
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 3

Shexli found 5 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • extension.js:376 
    win.unmaximize(Meta.MaximizeFlags.BOTH)
  • extension.js:608 
    win.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:375 
    win.get_maximized()
  • extension.js:607 
    win.get_maximized()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:64 
    this._wmSettings        = new Gio.Settings({ schema: WM_SCHEMA })
  • extension.js:254 
    this.settings         = this._extension.getSettings()

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:392 
                    GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                    if (win.get_display())
                        win.make_above();
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Previous Reviews on this Version

Domoel auto- rejected
Auto-rejected because of new version 23 was uploaded