Review of "Live Lock Screen" version 3.2.0 (6)

Details Page Preview

A GNOME Shell extension that lets you use any video/gif as your lock screen background. Features: • Video and gif playback with looping and optional audio • Multiple scaling modes • Blur and grayscale effects • Multi-monitor support Note: Requires GStreamer plugins to be installed. See the README on GitHub for more information. If you encounter bugs or issues, please report them on GitHub.

Extension Homepage
https://github.com/nick-redwill/LiveLockScreen

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-C49-002 error

extensions targeting GNOME 49 must not use removed Clutter action classes

This extension explicitly targets GNOME Shell 49 but still uses removed `Clutter.ClickAction` or `Clutter.TapAction`.

Clutter.ClickAction() and Clutter.TapAction()

  • extension.js:204
    new Clutter.TapAction()

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • external/command_handler.js
  • external/pipeline.js
  • external/player.js
  • external/run.js

All Versions

Version Status
3.2.0 (8) Active
3.2.0 (7) Rejected
3.2.0 (6) Rejected
3.0.0 (5) Active
4 Inactive
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. `Gst.init(null)` is enough. No need to do `Gst.init('')`. (`utils/safe_gst.js`). And `Gst.init` doesn't need to be wrapped in try-catch. 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. Try-catch not needed for destroy (line 163-177 `external/player.js`).