Review of "Live Lock Screen" version 3.0.0 (5)

Details Page Preview

A GNOME Shell extension that lets you use any video as your lock screen background. Features: • Video playback with looping and optional audio • Multiple scaling modes • Blur and grayscale effects • Multi-monitor support Note: Requires GStreamer plugins to be installed. See the README on GitHub for more information. If you encounter bugs or issues, please report them on GitHub.

Extension Homepage
https://github.com/nick-redwill/LiveLockScreen

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO026 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • external/command_handler.js
  • external/pipeline.js
  • external/player.js
  • external/run.js

EGO028 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • core/player_process.js:116
    GLib.spawn_command_line_sync(`kill ${this._pid}`)

EGO027 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:35
    this._settings = this.getSettings()

All Versions

Version Status
3.0.0 (5) Active
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active