Review of "WinKey Input Switcher" version 2

Details Page Preview

Hold Super key to temporarily switch to English input.

Extension Homepage
https://github.com/minh-quann/WinKey

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 17 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:95
    console.log(`[WinKey] Source ${i}: ${srcType}/${srcId} → "${engine}"`)
  • extension.js:108
    console.log(`[WinKey] Switching to index ${index}, engine="${engine}"`)
  • extension.js:164
    console.log(`[WinKey] Overview SHOWING: saved=${this._sourceBeforeOverview}, target=${targetIndex}`)
  • extension.js:179
    console.log(`[WinKey] Overview HIDDEN: restoreIndex=${restoreIndex}`)
  • extension.js:218
    console.log(`[WinKey] Terminal detected (${source}), switching to English`)
  • extension.js:233
    console.log(`[WinKey] Terminal left (${reason}), restoring previous source`)
  • extension.js:353
    console.log('[WinKey] Enabling extension v11 (with D-Bus helper)')
  • extension.js:370
    console.log(`[WinKey] Initial source: ${this._lastSourceIndex}`)
  • extension.js:414
    console.log('[WinKey] D-Bus helper service registered')
  • extension.js:419
    console.log('[WinKey] Extension enabled')

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:199
                    GLib.timeout_add(GLib.PRIORITY_HIGH, delay, () => {
                        this._switchTo(restoreIndex);
                        this._lastSourceIndex = restoreIndex;
                        return GLib.SOURCE_REMOVE;
                    })
  • extension.js:245
                        GLib.timeout_add(GLib.PRIORITY_HIGH, delay, () => {
                            this._switchTo(restoreIndex);
                            this._lastSourceIndex = restoreIndex;
                            return GLib.SOURCE_REMOVE;
                        })

All Versions

Version Status
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

buwin auto- rejected
Auto-rejected because of new version 3 was uploaded