Review of "WinKey Input Switcher" version 5

Details Page Preview

Hold Super key to temporarily switch to English input.

Extension Homepage
https://github.com/minh-quann/WinKey

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

buwin posted a review
Hi JustPerfection, thank you for the review! I have updated the extension to fix both issues: 1. Removed the unnecessary version specifiers from the imports in prefs.js. 2. Cleaned up extension.js by removing the redundant try-catch wrappers. I also refactored the _switchTo() function to rely solely on the standard InputSourceManager.activate() method instead of trying to force it in three different ways. The redundant _engineMap logic has been completely removed. I have also made sure not to include the gschemas.compiled file to comply with GNOME 45+ guidelines. The code is entirely manually maintained now. Please let me know if there's anything else!
JustPerfection rejected
Hi! Still `unexport()` and `disconnect` don't need try-catch wrappers. Please remove them and send it again.