Review of "Nothing to say" version 28

Details Page Preview

Unmute the microphone only when you have something to say.

Extension Homepage
https://github.com/wbolster/nothing-to-say

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:175
        this._microphone.connect("notify::active", () => {
          if (this._microphone.active) {
            this._panel_button.icon.add_style_class_name(
              MICROPHONE_ACTIVE_STYLE_CLASS,
            );
          } else {
            this._panel_button.icon.remove_style_class_name(
              MICROPHONE_ACTIVE_ST
  • extension.js:198
        this._microphone.connect("notify::muted", () => {
          this._panel_button.icon.icon_name = get_icon_name(this._microphone.muted);
        })
  • extension.js:206
        this._settings.connect("changed::icon-visibility", () => {
          this._panel_button.visible = this._icon_should_be_visible();
        })
  • extension.js:202
        this._settings.connect("changed::keybinding-mode", () => {
          Main.wm.removeKeybinding(KEYBINDING_KEY_NAME);
          this._addKeybinding();
        })
  • extension.js:137
          this._clickGesture.connect("recognize", (gesture) => {
            if (gesture.get_button() == Clutter.BUTTON_SECONDARY) {
              // Right click.
              extension.openPreferences();
            } else {
              extension._on_activate({ give_feedback: false });
            }
          })

All Versions

Version Status
30 Active
29 Active
28 Rejected
27 Active
26 Rejected
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Rejected
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Rejected
11 Rejected
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages.
wbolster posted a review
thanks! i've done extra cleanups; will upload new version now. latest commits here may simplify review https://github.com/wbolster/nothing-to-say
wbolster posted a review
thanks! i've done extra cleanups; will upload new version now. latest commits here may simplify review https://github.com/wbolster/nothing-to-say