Review "Selective Focus" version 1 - GNOME Shell Extensions

Review of "Selective Focus" version 1

Details Page Preview

Selective Focus

by MaourNournar

Force focus only for specific apps on Wayland

Extension Homepage: https://github.com/MaouNour/selective-focus-extension

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

.git/index
```
.git/index
```
.git/description
```
.git/description
```
.git/HEAD
```
.git/HEAD
```
.git/config
```
.git/config
```
.git/COMMIT_EDITMSG
```
.git/COMMIT_EDITMSG
```
.git/hooks/pre-push.sample
```
.git/hooks/pre-push.sample
```
.git/hooks/pre-merge-commit.sample
```
.git/hooks/pre-merge-commit.sample
```
.git/hooks/pre-applypatch.sample
```
.git/hooks/pre-applypatch.sample
```
.git/hooks/applypatch-msg.sample
```
.git/hooks/applypatch-msg.sample
```
.git/hooks/post-update.sample
```
.git/hooks/post-update.sample
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

schemas/gschemas.compiled
```
schemas/gschemas.compiled
```

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

extension.js:8

this._windowTracker = Shell.WindowTracker.get_default()

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

prefs.js:9
```
this._settings = this.getSettings()
```

prefs.js:25

        this._list = new Gtk.ListBox({
            selection_mode: Gtk.SelectionMode.NONE,
        })

All Versions

Version	Status
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected June 7, 2026

1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 3. Remove `.git` folder: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 4. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions