GNOME Shell Extensions

Review of "Selective Focus" version 3

Details Page Preview

Selective Focus

by MaourNournar

Force focus only for specific apps on Wayland

Extension Homepage
https://github.com/MaouNour/selective-focus-extension
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:9 
    this._settings = this.getSettings()
  • prefs.js:25 
            this._list = new Gtk.ListBox({
            selection_mode: Gtk.SelectionMode.NONE,
        })

All Versions

Version Status
4 Active
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Either null out `this._settings` and `this._list` in window close request or not hold them in `this`.
JustPerfection rejected
Either null out `this._settings` and `this._list` in window close request or not hold them in `this`.
MaourNournar posted a review
ah sorry to waste your time i didn't have the latest version i sent on my github page so i made this mistake i sent a new version