Review of "Activities Icon & Label" version 33

Details Page Preview

Show icon and label for panel Activities.

Extension Homepage
https://github.com/howbea/logo-activities

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:492
            this._settings.connect('changed::'+ KEY_PANEL, () => {
               this._indicator2?.destroy();
               this._indicator2 = null;
               if (this._settings.get_boolean(KEY_PANEL)) {
                this.panel_indicator();
                }
               })
  • extension.js:254
            this._settingsID = settings.connect("changed", () => {
                this.text_label = settings.get_boolean(KEY_LABEL);
                this.activities_icon = settings.get_boolean(KEY_ICON);
                this.text = settings.get_string(KEY_TEXT);
                this.activities_icon_name = settings.get

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:76
        getPreferencesWidget() {
            return buildPrefsWidget(this.getSettings());
        }

All Versions

Previous Reviews on this Version

JustPerfection active