Review of "User Style" version 15

Details Page Preview

Load shell themes from user directory.

Extension Homepage
https://github.com/howbea/Signal-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:22
    this._settings.connect(`changed::${SETTINGS_KEY}`, this._changeTheme.bind(this))
  • extension.js:35
            this._settings.connect('changed', () =>{ 
            if(this._settings.get_boolean('default-dark'))
            this._updateColorScheme('prefer-dark');
            else
            this._updateColorScheme('prefer-light'); 
            })

All Versions

Version Status
15 Active
14 Active
13 Active
12 Inactive
11 Active
10 Active
9 Inactive
8 Active
7 Inactive
6 Rejected
5 Rejected
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active