Review of "Desktop Logo" version 20

Details Page Preview

Add a logo to the desktop. This is a fork of Background Logo extension https://extensions.gnome.org/extension/889/background-logo/

Extension Homepage
https://github.com/howbea/logo-widget

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:101
            this._backgroundActor.content.connect('notify::brightness',
                this._updateOpacity.bind(this))
  • extension.js:77
            this._settings.connect('changed::logo-always-visible',
                this._updateVisibility.bind(this))
  • extension.js:71
            this._settings.connect('changed::logo-border',
                this._updateBorder.bind(this))
  • extension.js:63
            this._settings.connect('changed::logo-file-dark',
                this._updateLogo.bind(this))
  • extension.js:61
            this._settings.connect('changed::logo-file',
                this._updateLogo.bind(this))
  • extension.js:75
            this._settings.connect('changed::logo-opacity',
                this._updateOpacity.bind(this))
  • extension.js:69
            this._settings.connect('changed::logo-position',
                this._updatePosition.bind(this))
  • extension.js:65
            this._settings.connect('changed::logo-size', () => {
                this._updateScale();
                this.queue_relayout();
            })
  • extension.js:79
            this._settings.connect('changed::overview-visible', () => {
                this._settings.get_boolean('overview-visible');
            })
  • extension.js:73
            this._settings.connect('changed::y-logo-border',
                this._updateBorder.bind(this))
  • extension.js:84
            this._textureCache.connect('texture-file-changed', (cache, file) => {
                if (!this._logoFile || !this._logoFile.equal(file))
                    return;
                this._updateLogoTexture();
            })

All Versions

Previous Reviews on this Version

JustPerfection active