Review of "Vitals (Custom)" version 1

Details Page Preview

A customized fork of the Vitals extension with personal modifications to temperature, voltage, fan speed, memory usage, and processor load monitoring.

Extension Homepage
https://github.com/minh-quann/Vitals

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • check_keys.js
  • get_issues.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:441
            this._menuStateChangeId = this.menu.connect('open-state-changed', (self, isMenuOpen) => {
                if (isMenuOpen) {
                    // make sure timer fires at next full interval
                    this._updateTimeChanged();
    
                    // refresh sensors now
                    this._quer
  • extension.js:728
    this._settings.connect('changed::' + key, callback)

All Versions

Version Status
5 Unreviewed
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

buwin auto- rejected
Auto-rejected because of new version 2 was uploaded