Review of "Vitals (Custom)" version 2

Details Page Preview

A customized fork of the Vitals extension with personal modifications to temperature, voltage, fan speed, memory usage, and processor load monitoring.

Extension Homepage
https://github.com/minh-quann/Vitals

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:728
    this._settings.connect('changed::' + key, callback)

All Versions

Version Status
5 Unreviewed
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

buwin auto- rejected
Auto-rejected because of new version 3 was uploaded